Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-3236) Only set ruby env vars on local transport when they exist #3240

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

donoghuc
Copy link
Contributor

@donoghuc donoghuc commented Oct 4, 2023

Previously we would attempt to use any prior environment variables captured when bolt was invoked by simply looking for those existing. This works when those exist but in the case they did not exist the environment variables were set to empty strings. This makes it impossible to load ruby code (for example to do an apply on local transport). This commit updates the local transport to only set those environment variables if they are explicitly set to something other than an empty string.

!bug

  • Only set ruby env vars for local transport when non empty strings (#3236)

    Previously when using bundled-ruby=false for the local transport and not expliclty setting ruby environment variables internal apply tasks did not work due to ruby code not being able to be loaded. Now the local transport only preserves ruby environment variables when they are set to something other than an empty string.

…ey exist

Previously we would attempt to use any prior environment variables captured when bolt was invoked by simply looking for those existing. This works when those exist but in the case they did not exist the environment variables were set to empty strings. This makes it impossible to load ruby code (for example to do an apply on local transport). This commit updates the local transport to only set those environment variables if they are explicitly set to something other than an empty string.

!bug

* **Only set ruby env vars for local transport when non empty strings**
  ([puppetlabs#3236](puppetlabs#3236))

  Previously when using bundled-ruby=false for the local transport and
  not expliclty setting ruby environment variables internal apply tasks
  did not work due to ruby code not being able to be loaded. Now the local
  transport only preserves ruby environment variables when they are set
  to something other than an empty string.
@donoghuc donoghuc requested a review from a team as a code owner October 4, 2023 23:04
@mcdonaldseanp mcdonaldseanp merged commit 73be078 into puppetlabs:main Oct 5, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants